Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python binding for SSL_set1_groups_list method #58

Merged
merged 9 commits into from Oct 4, 2020

Conversation

fabian-hk
Copy link
Contributor

Python binding for SSL_set1_groups_list method for the sslyze pull request #410.

@nabla-c0d3 nabla-c0d3 changed the base branch from master to release June 20, 2020 23:05
@fabian-hk
Copy link
Contributor Author

@nabla-c0d3 I am not sure why the checks fail. Can you give me a hint on what went wrong?

@nabla-c0d3
Copy link
Owner

@fabian-hk you should be able to reproduce the error by running invoke test. It looks like a file that has a formatting that's not compliant with black.

@fabian-hk
Copy link
Contributor Author

Fixed it! I did not know that I had to use black for the formatting. Is this somewhere documented?

@fabian-hk
Copy link
Contributor Author

@nabla-c0d3 Please allow me to draw your attention to this pull request again. Would it be possible for you to merge it? It would really help the tlsprofiler project and in particular this issue!

@nabla-c0d3
Copy link
Owner

@fabian-hk Yeah I would like to get to it soon - it's an important PR. Thanks again!

@fabian-hk
Copy link
Contributor Author

@nabla-c0d3 What is the status of this pull request?

@nabla-c0d3 nabla-c0d3 added this to To do in 3.1.0 Oct 3, 2020
@nabla-c0d3 nabla-c0d3 merged commit 29b505d into nabla-c0d3:release Oct 4, 2020
@nabla-c0d3
Copy link
Owner

Thanks again! FYI I am going to tweak the API and switch to an enum for the possible groups.

@nabla-c0d3
Copy link
Owner

@fabian-hk if you have time, please double check the commit just above this comment and let me know your thoughts. Thanks!

@nabla-c0d3 nabla-c0d3 moved this from To do to Done in 3.1.0 Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.1.0
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants