Point to upstream solo5/solo5 and enable solo5 tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ricarkol
commented
Jan 25, 2019
•
ricarkol
commented
- Adding solo5/solo5 master repo as a submodule.
- Adding solo5 to runtests.sh and updated travis to run them.
- Now build-rr.sh builds and copies the solo5 libraries to their location. There is an objcopy to change stack guard symbols that were in conflict with the rumprun libc.
- The old bake rules were called ukvm-* and seccomp-*. Changed that to solo5-hvt and solo5-spt.
added 2 commits
January 24, 2019 18:36
Signed-off-by: Ricardo Koller <kollerr@us.ibm.com>
ricarkol
changed the title
added 2 commits
January 25, 2019 13:38
- Now build-rr.sh builds and copies the solo5 libraries to their location. There is an objcopy to change stack guard symbols that were in conflict with the rumprun libc. - The old bake rules were called ukvm-* and seccomp-*. Changed that to solo5-hvt and solo5-spt. - travis: using xenial ubuntu (need a newer gcc) Signed-off-by: Ricardo Koller <kollerr@us.ibm.com>
Signed-off-by: Ricardo Koller <kollerr@us.ibm.com>
ricarkol
changed the title
lumjjb
approved these changes
Jan 25, 2019
| @@ -200,7 +201,8 @@ checksubmodules () | |||
| # We assume that if the git submodule command fails, it's because | |||
| # we're using external $RUMPSRC. | |||
| if git submodule status ${RUMPSRC} 2>/dev/null | grep -q '^-' \ | |||
| || git submodule status ${BUILDRUMP} 2>/dev/null | grep -q '^-'; | |||
| || git submodule status ${BUILDRUMP} 2>/dev/null | grep -q '^-' \ | |||
| || git submodule status ${SOLO5SRC} 2>/dev/null | grep -q '^-'; | |||
There was a problem hiding this comment.
ahh, that was on purpose:
if git submodule status ${RUMPSRC} 2>/dev/null | grep -q '^-' \
|| git submodule status ${BUILDRUMP} 2>/dev/null | grep -q '^-' \
|| git submodule status ${SOLO5SRC} 2>/dev/null | grep -q '^-';
thought that this looked prettier than:
if git submodule status ${RUMPSRC} 2>/dev/null | grep -q '^-' \
|| git submodule status ${BUILDRUMP} 2>/dev/null | grep -q '^-' \
|| git submodule status ${SOLO5SRC} 2>/dev/null | grep -q '^-';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.