Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker receives focus when user hovers over buttons #89

Closed
nadchif opened this issue May 19, 2020 · 4 comments
Closed

Picker receives focus when user hovers over buttons #89

nadchif opened this issue May 19, 2020 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation first-timers-only good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@nadchif
Copy link
Owner

nadchif commented May 19, 2020

Describe the bug
When you hover over the button carets, and you move your mouse away, the picker receives focus

To Reproduce
Steps to reproduce the behavior:

  1. Load a page with a duration picker input box
  2. Move your mouse to hover either a up ^ or v button.
  3. Without clicking anything, move your mouse away.

Expected behavior
If a user hovers past a button, the picker should automatically get focus

Screenshots
bugdemo

Desktop (please complete the following information):

  • OS: MacOS 14
  • Browser: Chrome
  • Version: 81
@nadchif nadchif added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers first-timers-only up-for-grabs labels May 19, 2020
@Kharanshu31
Copy link
Contributor

Hi,I want to work on this and please guide me through

@nadchif
Copy link
Owner Author

nadchif commented May 20, 2020

Sure, thank you ☺
Please to through this for a step by step guide https://github.com/nadchif/html-duration-picker.js/blob/master/CONTRIBUTING.md

Feel welcome to reach out again if you still need assistance

@Kharanshu31
Copy link
Contributor

so basically i have to remove the focus when we move the mouse away?

@nadchif
Copy link
Owner Author

nadchif commented May 20, 2020

so basically i have to remove the focus when we move the mouse away?

The idea is to prevent the picker from getting focus IF the mouse leaves, and the buttons had not been clicked.
If the buttons have been clicked, the picker must receive focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation first-timers-only good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants