Update to remove unnecessary focus #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line number 386 was unnecessarily focusing the picker when mouse moves away
You certainly got that right! Great job 👏 . This does fix #89 I've modified your code a bit, because we still need the Please take a look, and let me know if there are any concerns before I go ahead and merge |
|
The above changes looks good |
|
Thank you for your contribution. @all-contributors please add @Kharanshu31 for code |
|
I've put up a pull request to add @Kharanshu31! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line number 386 was unnecessarily focusing the picker when mouse moves away