Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed passing --gracetime through to slop. #5

Closed
wants to merge 1 commit into from

Conversation

ben0x539
Copy link

No description provided.

@ben0x539
Copy link
Author

As gcc pointed out:

main.cpp:140:53: warning: format ‘%i’ expects argument of type ‘int’, but argument 7 has type ‘char*’ [-Wformat]

This had the effect of passing the pointer's numeric value to slop, resulting in an invocation like slop -b 5 -p 0 -t 2 -g 32358608 -c 0.5,0.5,0.5,1 --min=0 --max=0

@ben0x539
Copy link
Author

Actually this patch breaks your sprintf for pathological inputs passed to --gracetime, overflowing the slopcommand buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant