Fixed the problem with escorts (I think).

[onpon4]

Not tested thoroughly yet, but I think this should fix the problem of
escorts causing segfaults when their origin ship dies. A cursory test
shows that this seems to work.

This also causes pilot.setLeader to remove "deployed" status from the
origin ship.

[ids1024]

Calling assert broke the Travis build. If you want to do that, include assert.h.

[onpon4]

I've added an include for assert.h and changed player_dt_default to a function.

I'm not sure about switching up the way dockpilot and dockslot are stored, it's not going to improve efficiency any (and in fact can make it worse because it adds more looping). That it involves passing pointers around is true enough but failure to clean up the other values properly can cause bugs too (just bugs that would be less obvious like choosing the wrong ship as a dockpilot and then trying to dock on a slot that it doesn't belong in).

[onpon4]

Now, if every single ship that could possibly have the destroyed pilot as a dockslot will always be in the escort list, that can be used to reduce looping a bit. That looks rather flimsy to me, though, and I don't think that's really worth it when the pilots have to be looped through all the time anyway.

[onpon4]

There we go, switched it up to use ints instead of pointers.

[ids1024]

Do you see my point about just removing the loop from pilot_destroy, or am I missing something? All that code does is setting dockpilot and dockslot to 0 and -1. Without that loop, those variables will be set the same way the next time pilot_getDockSlot() is called.

Otherwise, the changes here look good. 👍

[onpon4]

Ahhhhhhh, I see what you're saying. That does make sense come to think of it. Lemme do that...

[onpon4]

There we go, I've pushed that through. Seems to work.