Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Laravel Passport #25

Merged
merged 18 commits into from
Aug 25, 2019
Merged

Implement Laravel Passport #25

merged 18 commits into from
Aug 25, 2019

Conversation

kresnasatya
Copy link
Contributor

Halo mas @nafiesl , saya telah membuatkan fitur autentikasi menggunakan Laravel passport seperti di isu #24 . Untuk mengetes REST client bisa dibuka di Insomnia atau Postman. Filenya ada di commit a1faf2b.

@nafiesl
Copy link
Owner

nafiesl commented Aug 25, 2019

Ok mas @satyakresna ini testnya sudah passed. Saya sudah coba di localhost dan bekerja lancar.

Tapi coveragenya belum passed, karena Api\AuthController belum tersentuh test. Nanti saya lanjutkan untuk bikin test nya yang bagian itu 👍

@kresnasatya
Copy link
Contributor Author

Halo mas @nafiesl , ada yang typo nih dibagian kata emil mestinya email: 3cad7a0

@nafiesl
Copy link
Owner

nafiesl commented Aug 25, 2019

Ups, typo fixed mas @satyakresna, makasih mas. 🙏

@kresnasatya
Copy link
Contributor Author

Ok mas @satyakresna ini testnya sudah passed. Saya sudah coba di localhost dan bekerja lancar.

Tapi coveragenya belum passed, karena Api\AuthController belum tersentuh test. Nanti saya lanjutkan untuk bikin test nya yang bagian itu 👍

Mantap. Makasih banyak mas @nafiesl . 🙏

@nafiesl
Copy link
Owner

nafiesl commented Aug 25, 2019

mas @satyakresna saya belum ketemu caranya untuk nge-test login API dengan passport. Mungkin kita lewati dulu bagian ini. Karena secara fiturnya sudah bekerja dengan baik, maka PR ini akan saya merge.

Nanti kita pikirkan belakangan untuk test Api\Auth\AuthController nya (jadi coveragenya biar fails dulu).

@nafiesl nafiesl merged commit 4f37583 into nafiesl:master Aug 25, 2019
@kresnasatya kresnasatya deleted the implement-passport branch March 8, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants