Api login consistency #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nafiesl
requested changes
Jan 19, 2020
| public function login(Request $request) | ||
| { | ||
| $this->validator($request->all())->validate(); |
There was a problem hiding this comment.
Mas @satyakresna, kenapa kita ngga pakai request validator aja disini mas?
$request->validate([
'email' => 'required|string|email',
'password' => 'required|string',
]);
There was a problem hiding this comment.
Oh iya juga ya. Saya perbaiki. :)
nafiesl
requested changes
Jan 19, 2020
| @@ -32,6 +38,8 @@ public function logout() | |||
| $token->revoke(); | |||
| }); | |||
|
|
|||
| return response()->json('Logged out successfully', 200); | |||
| return response()->json(array( | |||
There was a problem hiding this comment.
mas @satyakresna kita pakai array yang kekinian aja mas:
[
'message' => 'Logged out successfully',
]
nafiesl
approved these changes
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halo mas, saya ada pembaharuan di route auth API pakai Laravel Passport:
logoutkonsisten dengan routelogindi sisi path.