Apply fixes from StyleCI

app/Console/Kernel.php

@@ -19,7 +19,8 @@ class Kernel extends ConsoleKernel
     /**
      * Define the application's command schedule.
      *
-     * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
+     * @param \Illuminate\Console\Scheduling\Schedule $schedule
+     *
      * @return void
      */
     protected function schedule(Schedule $schedule)

app/Entities/BaseRepository.php

@@ -9,13 +9,12 @@
 use App\Entities\Users\User;
 
 /**
- * Base Repository Class
+ * Base Repository Class.
  *
  * @author Nafies Luthfi <nafiesL@gmail.com>
  */
 abstract class BaseRepository extends EloquentRepository
 {
-
     public function getCustomersList()
     {
         return Customer::orderBy('name')->pluck('name', 'id');
@@ -27,6 +26,7 @@ public function getCustomersAndVendorsList()
             'Customer' => Customer::orderBy('name')->pluck('name', 'id')->all(),
             'Vendor'   => Vendor::orderBy('name')->pluck('name', 'id')->all(),
         ];
+
         return $partners;
     }
 

app/Entities/EloquentRepository.php

@@ -6,7 +6,7 @@
 use Illuminate\Database\Eloquent\Model;
 
 /**
- * Eloquent Repository Class
+ * Eloquent Repository Class.
  *
  * @author Nafies Luthfi <nafiesL@gmail.com>
  */
@@ -71,29 +71,30 @@ public function create($data)
                 if ($data[$key] == '') {
                     $data[$key] = null;
                 }
-
             }
+
             return $this->storeArray($data);
         }
     }
 
-    public function update($data = [], $modelId)
+    public function update($data, $modelId)
     {
         foreach ($data as $key => $value) {
             if (!$data[$key]) {
                 $data[$key] = null;
             }
-
         }
 
         $model = $this->requireById($modelId);
         $model->update($data);
+
         return $model;
     }
 
     public function delete($modelId)
     {
         $model = $this->requireById($modelId);
+
         return $model->delete();
     }
 
@@ -110,6 +111,7 @@ protected function storeArray($data)
     {
         $model = $this->getNewInstance($data);
         $this->storeEloquentModel($model);
+
         return $model;
     }
 }

app/Entities/Invoices/Invoice.php

@@ -45,6 +45,7 @@ public function generateNewNumber()
                 return ++$lastInvoiceNo;
             }
         }
+
         return $prefix.'001';
     }
 

app/Entities/Options/Option.php

@@ -4,9 +4,9 @@
 
 use Illuminate\Database\Eloquent\Model;
 
-class Option extends Model {
-
-    protected $fillable = ['key','value'];
+class Option extends Model
+{
+    protected $fillable = ['key', 'value'];
     protected $table = 'site_options';
-	public $timestamps = false;
+    public $timestamps = false;
 }

app/Entities/Payments/Payment.php

@@ -2,7 +2,6 @@
 
 namespace App\Entities\Payments;
 
-use App\Entities\Payments\PaymentPresenter;
 use App\Entities\Projects\Project;
 use Illuminate\Database\Eloquent\Model;
 use Laracasts\Presenter\PresentableTrait;

app/Entities/Payments/PaymentPresenter.php

@@ -25,4 +25,4 @@ public function type()
     {
         return paymentTypes($this->entity->type_id);
     }
-}
+}

app/Entities/Payments/PaymentsRepository.php

@@ -5,7 +5,7 @@
 use App\Entities\BaseRepository;
 
 /**
- * Payments Repository Class
+ * Payments Repository Class.
  *
  * @author Nafies Luthfi <nafiesL@gmail.com>
  */

app/Entities/Projects/Job.php

@@ -2,15 +2,12 @@
 
 namespace App\Entities\Projects;
 
-use App\Entities\Projects\JobPresenter;
-use App\Entities\Projects\Project;
 use App\Entities\Users\User;
 use Illuminate\Database\Eloquent\Model;
 use Laracasts\Presenter\PresentableTrait;
 
 class Job extends Model
 {
-
     use PresentableTrait;
 
     protected $presenter = JobPresenter::class;
@@ -35,5 +32,4 @@ public function type()
     {
         return $this->type_id == 1 ? 'Project' : 'Additional';
     }
-
 }

app/Entities/Projects/JobPresenter.php

@@ -20,5 +20,4 @@ public function projectJobsLink()
     {
         return link_to_route('projects.jobs.index', trans('project.jobs'), [$this->project_id]);
     }
-
 }

app/Entities/Projects/JobsRepository.php

@@ -3,7 +3,6 @@
 namespace App\Entities\Projects;
 
 use App\Entities\BaseRepository;
-use App\Entities\Projects\Project;
 use DB;
 
 /**
@@ -40,6 +39,7 @@ public function requireProjectById($projectId)
     public function createJob($jobData, $projectId)
     {
         $jobData['project_id'] = $projectId;
+
         return $this->storeArray($jobData);
     }
 
@@ -77,13 +77,12 @@ public function requireTaskById($taskId)
         return Task::findOrFail($taskId);
     }
 
-    public function update($jobData = [], $jobId)
+    public function update($jobData, $jobId)
     {
         foreach ($jobData as $key => $value) {
             if (!$jobData[$key]) {
                 $jobData[$key] = null;
             }
-
         }
 
         $jobData['price'] = str_replace('.', '', $jobData['price']);

app/Entities/Projects/Project.php

@@ -5,8 +5,6 @@
 use App\Entities\Invoices\Invoice;
 use App\Entities\Partners\Customer;
 use App\Entities\Payments\Payment;
-use App\Entities\Projects\ProjectPresenter;
-use App\Entities\Projects\Task;
 use App\Entities\Subscriptions\Subscription;
 use Illuminate\Database\Eloquent\Model;
 use Laracasts\Presenter\PresentableTrait;
@@ -131,5 +129,4 @@ public function getJobList($jobType)
             ->with('worker', 'tasks')
             ->get();
     }
-
 }

app/Entities/Projects/ProjectPresenter.php

@@ -35,5 +35,4 @@ public function workDuration()
 
         return $workDuration.' Hari';
     }
-
 }

app/Entities/Projects/ProjectsRepository.php

@@ -8,7 +8,7 @@
 use ProjectStatus;
 
 /**
- * Projects Repository Class
+ * Projects Repository Class.
  */
 class ProjectsRepository extends BaseRepository
 {
@@ -29,7 +29,6 @@ public function getProjects($q, $statusId)
                 if ($statusId && in_array($statusId, $statusIds)) {
                     $query->where('status_id', $statusId);
                 }
-
             })
             ->withCount('payments')
             ->with('customer')
@@ -50,6 +49,7 @@ public function create($projectData)
 
         $project = $this->storeArray($projectData);
         DB::commit();
+
         return $project;
     }
 
@@ -60,7 +60,7 @@ public function getStatusName($statusId)
 
     public function createNewCustomer($customerName, $customerEmail)
     {
-        $newCustomer = new Customer;
+        $newCustomer = new Customer();
         $newCustomer->name = $customerName;
         $newCustomer->email = $customerEmail;
         $newCustomer->save();
@@ -88,6 +88,7 @@ public function delete($projectId)
         $project->delete();
 
         DB::commit();
+
         return 'deleted';
     }
 

app/Entities/Projects/Status.php

@@ -41,7 +41,7 @@ public static function getNameById($singleId)
 
     public static function getIconById($singleId)
     {
-        if (!!static::getById($singleId) && isset(static::$icons[$singleId])) {
+        if ((bool) static::getById($singleId) && isset(static::$icons[$singleId])) {
             return static::$icons[$singleId];
         }
 

app/Entities/Projects/Task.php

@@ -2,13 +2,11 @@
 
 namespace App\Entities\Projects;
 
-use App\Entities\Projects\TaskPresenter;
 use Illuminate\Database\Eloquent\Model;
 use Laracasts\Presenter\PresentableTrait;
 
 class Task extends Model
 {
-
     use PresentableTrait;
 
     protected $presenter = TaskPresenter::class;
@@ -18,5 +16,4 @@ public function job()
     {
         return $this->belongsTo(Job::class, 'project_id');
     }
-
 }

app/Entities/Projects/TasksRepository.php

@@ -5,7 +5,7 @@
 use App\Entities\BaseRepository;
 
 /**
- * Tasks Repository Class
+ * Tasks Repository Class.
  */
 class TasksRepository extends BaseRepository
 {
@@ -19,6 +19,7 @@ public function __construct(Task $model)
     public function createTask($taskData, $jobId)
     {
         $taskData['job_id'] = $jobId;
+
         return $this->storeArray($taskData);
     }
 

app/Entities/ReferenceAbstract.php

@@ -6,7 +6,7 @@
 use Illuminate\Support\Arr;
 
 /**
- * Base of References class
+ * Base of References class.
  *
  * @author Nafies Luthfi <nafiesL@gmail.com>
  */
@@ -57,7 +57,7 @@ public static function colors()
 
     public static function getColorById($colorId)
     {
-        if (!!static::getById($colorId) && isset(static::$colors[$colorId])) {
+        if ((bool) static::getById($colorId) && isset(static::$colors[$colorId])) {
             return static::$colors[$colorId];
         }
 

app/Entities/Reports/ReportsRepository.php

@@ -8,7 +8,7 @@
 use DB;
 
 /**
- * Reports Repository Class
+ * Reports Repository Class.
  *
  * @author Nafies Luthfi <nafiesL@gmail.com>
  */
@@ -31,9 +31,9 @@ public function getDailyReports($date, $q)
 
     public function getMonthlyReports($year, $month)
     {
-        $rawQuery = "date, count(`id`) as count";
-        $rawQuery .= ", sum(if(in_out = 1, amount, 0)) AS cashin";
-        $rawQuery .= ", sum(if(in_out = 0, amount, 0)) AS cashout";
+        $rawQuery = 'date, count(`id`) as count';
+        $rawQuery .= ', sum(if(in_out = 1, amount, 0)) AS cashin';
+        $rawQuery .= ', sum(if(in_out = 0, amount, 0)) AS cashout';
 
         $reportsData = DB::table('payments')->select(DB::raw($rawQuery))
             ->where(DB::raw('YEAR(date)'), $year)
@@ -54,10 +54,10 @@ public function getMonthlyReports($year, $month)
 
     public function getYearlyReports($year)
     {
-        $rawQuery = "MONTH(date) as month";
-        $rawQuery .= ", count(`id`) as count";
-        $rawQuery .= ", sum(if(in_out = 1, amount, 0)) AS cashin";
-        $rawQuery .= ", sum(if(in_out = 0, amount, 0)) AS cashout";
+        $rawQuery = 'MONTH(date) as month';
+        $rawQuery .= ', count(`id`) as count';
+        $rawQuery .= ', sum(if(in_out = 1, amount, 0)) AS cashin';
+        $rawQuery .= ', sum(if(in_out = 0, amount, 0)) AS cashout';
 
         $reportsData = DB::table('payments')->select(DB::raw($rawQuery))
             ->where(DB::raw('YEAR(date)'), $year)
@@ -80,9 +80,9 @@ public function getCurrentCredits()
     {
         // On Progress, Done, On Hold
         $projects = Project::whereIn('status_id', [2, 3, 6])->with('payments', 'customer')->get();
+
         return $projects->filter(function ($project) {
             return $project->cashInTotal() < $project->project_value;
         })->values();
     }
-
 }

app/Entities/Subscriptions/SubscriptionPresenter.php

@@ -8,6 +8,6 @@ class SubscriptionPresenter extends Presenter
 {
     public function customerNameAndEmail()
     {
-        return $this->customer_id ? $this->customer->name  . ' (' . $this->customer->email . ')' : '-';
+        return $this->customer_id ? $this->customer->name.' ('.$this->customer->email.')' : '-';
     }
-}
+}

app/Entities/Subscriptions/SubscriptionsRepository.php

@@ -5,7 +5,7 @@
 use App\Entities\BaseRepository;
 
 /**
- * Subscriptions Repository Class
+ * Subscriptions Repository Class.
  */
 class SubscriptionsRepository extends BaseRepository
 {
@@ -28,7 +28,6 @@ public function getSubscriptions($q, $customerId)
                 if ($q) {
                     $query->where('name', 'like', '%'.$q.'%');
                 }
-
             })
             ->with('customer', 'vendor')
             ->paginate($this->_paginate);