Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing semi-transparent pngs #27

Closed
williammalo opened this issue Jun 15, 2015 · 5 comments · Fixed by #28
Closed

Processing semi-transparent pngs #27

williammalo opened this issue Jun 15, 2015 · 5 comments · Fixed by #28

Comments

@williammalo
Copy link

When trying to process semi-transparent pngs, a white background is added.
I have a project where I need to upscale images, and waifu2x is the only algorithm that looks good enough, but unfortunately, I can't use it for semi-transparent image :(

@nagadomi
Copy link
Owner

I fixed this issue and updated the demo-application.

@williammalo
Copy link
Author

great! I'm so happy!!! you are doing a great service to mankind

@leilei-
Copy link

leilei- commented Jun 17, 2015

Thanks. I had to use an annoying imagemagick-based workaround of splitting the alpha to a separate image for Waifu2x to process in a batch, and it wasn't always reliable because Imagemagick is not consistent with reassembling images from components.

@nagadomi
Copy link
Owner

My implementation is similar to ImageMagick solution.
The alpha channel is scaled with generic image scaler.

@nagadomi
Copy link
Owner

nagadomi commented Dec 3, 2015

Fixed #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants