-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waifu2x doesn't handle transparency properly #29
Comments
If I understand correctly you want to keep the edges crispy? |
@nodegin that would make the image pixellated :) |
This is also an issue for me as well. It was super fun converting old game assets that I had lost files over, but the sadness of making them transparent was :( |
I think waifu2x is not good at pixelated image scaling... |
Not sure if this is worth mentioning, but earlier versions of waifu2x-caffee could produce transparent images with sharp edges. |
@internetakias Do you know an exact version where it was working? If we can find the commit that broke it, we should be able to solve it easily. |
@PwnicornDev |
Hey @nagadomi. You haven't replied to this issue yet, so I want to ask you what you think of this and if there's a way to fix it. |
The latest version slightly improves for this issue but still not enough. |
I understand. Thanks for replying and keep up the good work! |
- make border - scale the alpha channel by waifu2x - composite
I fixed this issue. try http://waifu2x.udp.jp/ |
How is waifu2x supposed to do? EDIT: I understood what you said. I will fix it soon. |
Unfortunately, it is a feature of the original game, and such areas should be.
(The first - the background, the rest - imposed on the background image with transparency, similar to the above). |
I fixed that file size problem. before fix: 740888 bytes And, if image has alpha channel, 2x process time is required. alpha channel upscaling with waifu2x improves the upscaling result in some case. |
Yes, the local version has updated and checked. |
Examples:
Expected Result
![good](https://cloud.githubusercontent.com/assets/1521848/8187062/d676dfee-141b-11e5-99a2-9170cf60c563.png)
![bad](https://cloud.githubusercontent.com/assets/1521848/8187065/dd47633e-141b-11e5-9d71-a4afe50bbcf2.png)
Actual Result
To get the example image with good transparency, I ran waifu2x on the image over a black background and over a white background and compared the two with a filter. This proves that waifu2x does work properly if the background isn't semi-transparent
Original image:
![sapling_spruce-white](https://cloud.githubusercontent.com/assets/1521848/8187260/ea86a1da-141c-11e5-8a13-97ad5bc20b0d.png)
The text was updated successfully, but these errors were encountered: