Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring HolidayProvider #622

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Refactoring HolidayProvider #622

merged 4 commits into from
Mar 20, 2024

Conversation

BelmoMusta
Copy link
Contributor

In order not to repeat these instructions that are found in so many classes:

var holidays = HolidaySpecificationProcessor.Process(holidaySpecifications, countryCode);
return holidays.OrderBy(o => o.Date);

This logic is refactored in one abstract class AbstractHolidayProvider, which is inherited by other countries' providers

@tinohager
Copy link
Member

@samtrion These are actually the changes we've already discussed, and I think they would suit me.

@tinohager tinohager requested a review from samtrion March 20, 2024 07:42
@samtrion
Copy link
Collaborator

The approach suits me and is complete with regard to the architecture tests.

@tinohager tinohager merged commit 8e38b58 into nager:main Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants