Explicitly passed IDs take precedence over anything #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We extract a function that sets the filtered attribute on tasks if the task ID matches IDs explicitly passed at the command line. Add a unit test for this logic. Refs naggie#44
dontlaugh
force-pushed
the
44_task_indexing
branch
from
9584e83
to
b06b60e
Compare
|
@naggie I believe this should fix 44, or at least alleviate the situation. Filtering relies on setting fields on an array of Task pointers, so I have created a private function to encapsulate this for IDs, and added a unit test. We can do the same for filtering on other task attributes (tags, projects), in a follow up PR. |
5 tasks
|
See #59 -- I suggest this is merged into a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extract a function that sets the filtered attribute on tasks if the
task ID matches IDs explicitly passed at the command line. Add a unit
test for this logic.
Refs #44