plugins/check_http: chunked Transfer-Encoding #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs only if HTTP_CHUNKED (env) is set, fails obviously
Change-Id: I8188b3be4f0fec756b5ab0f20122632a29a676ce
Change-Id: I9538983c3039f710f838329f5a0f6d0fd6597da7
Change-Id: Id52847dac96a47fd636c74bb8d659c8d295bced2
Change-Id: I17bff5ccfdeb92cb1a0253119e1c3b36023d8d6e
|
Thanks! I'll review and consider adding this to 2.1 in the very near future. |
|
Merged these into the 2.1 beta branch today. Had a good long test of it, and most things seem to work well. I only had a little bit of cleanup for our up comming coding standards, and a small change to your logic. Otherwise nice work! I love the automatic handling of this, but will have to do some further testing to make sure it can't be tricked too easily. My final patch at the moment is f5cd931, and I will be closing this pr as it is completed. If you would like to revise it further, please post another comment below. Thanks again for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach
check_httpabout "Transfer-Encoding: chunked".