Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added test for NTLM authentication #146

Merged
merged 2 commits into from Dec 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

johncant commented Mar 1, 2013

Hi nahi,

I wasn't convinced that NTLM authentication worked in httpclient, so I wrote a test for it. Turns out that rubyntlm wasn't generating the type 3 message correctly. I'm submitting another pull request to rubyntlm. https://github.com/johncant/rubyntlm should have fixed it.

John

Hiroshi Nakamura » httpclient #64 FAILURE
Looks like there's a problem with this pull request
(what's this?)

Contributor

johncant commented Mar 1, 2013

These tests will pass after I https://github.com/wimm merges my changes to rubyntlm, now that I've pushed rack-ntlm-test-service to rubygems.

@nahi nahi added a commit that referenced this pull request Dec 2, 2013

@nahi nahi Merge pull request #146 from johncant/master
Added test for NTLM authentication
0f6d1d1

@nahi nahi merged commit 0f6d1d1 into nahi:master Dec 2, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Contributor

johncant commented Dec 2, 2013

Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment