Added test for NTLM authentication #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hiroshi Nakamura » httpclient #64 FAILURE |
|
These tests will pass after I https://github.com/wimm merges my changes to rubyntlm, now that I've pushed rack-ntlm-test-service to rubygems. |
nahi
pushed a commit
that referenced
this pull request
Dec 2, 2013
Added test for NTLM authentication
|
Thankyou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi nahi,
I wasn't convinced that NTLM authentication worked in httpclient, so I wrote a test for it. Turns out that rubyntlm wasn't generating the type 3 message correctly. I'm submitting another pull request to rubyntlm. https://github.com/johncant/rubyntlm should have fixed it.
John