Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'from' method can be renamed to 'at' #6

Closed
me-shaon opened this issue May 10, 2018 · 4 comments
Closed

'from' method can be renamed to 'at' #6

me-shaon opened this issue May 10, 2018 · 4 comments

Comments

@me-shaon
Copy link
Contributor

@s1s1ty apu had a problem implementing 'from' as a method name in her python implementation because it's a reserved word in python. We discussed and agreed that it can be renamed to 'at' and it seems quite good enough and meaningful. You can consider it.
@nahid
Copy link
Owner

nahid commented May 11, 2018

Yes thats an awesome idea, but if possible we can keep 'from' method along side with 'at' as an alias.

@me-shaon
Copy link
Contributor Author

Yup. That's good too. Should I go ahead and make a PR?

@nahid
Copy link
Owner

nahid commented May 11, 2018

sure bhai

me-shaon added a commit to me-shaon/jsonq that referenced this issue May 11, 2018
@me-shaon
Fixed issue nahid#6 : at() method added as an alias for from() method
1ae09d1
@nahid nahid closed this as completed May 17, 2018
@nahid
Copy link
Owner

nahid commented Nov 9, 2023

Comment from Ostad Class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@me-shaon @nahid