This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add automatic upload flag on false no-upload flag #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anderssonw <wandersson.98@gmail.com>
|
Totally fair 👍🏾 merge and release as soon as its finished. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to add the attestation to the transparency log as the
--yesflag was unset.Also I've noticed that keyless signatures work, but keyless verifies are not possible due to those requiring a couple flags. Added a TODO for this as it is not necessary for our use case, but should nonetheless be a feature.
The attest-verify command is really janky, should probably split it as a subcommand, as mentioned in a TODO