Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button is incorrect if the browser doesn't support the character #19

Closed
jsumners opened this issue Feb 28, 2014 · 3 comments
Closed

Close button is incorrect if the browser doesn't support the character #19

jsumners opened this issue Feb 28, 2014 · 3 comments

Comments

@jsumners
Copy link

The character used for the close button, "×", does not always render correctly. It would be better to use "×" (×).
@nakupanda
Copy link
Owner

Great, I'm on it, thanks.

nakupanda added a commit that referenced this issue Mar 3, 2014
@nakupanda
Squashed commit of the following:
e483f86 
commit 97ad988c6489c000e428a08123d690ab98bd9c2d
Author: Dante <javanoob@hotmail.com>
Date:   Mon Mar 3 09:39:52 2014 +0800

    Update bootstrap to v3.1.1

commit 9645fcae47228562939f7fa285b5d7c46b65551d
Author: Dante <javanoob@hotmail.com>
Date:   Mon Mar 3 09:13:20 2014 +0800

    #19 Change label of Close button from special character to html entities
@nakupanda
Copy link
Owner

Changed as you suggested.

<3

@jsumners
Copy link
Author

jsumners commented Mar 3, 2014

Excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsumners @nakupanda