Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of front-end of blast app #36

Closed
hsiaoyi0504 opened this issue Sep 18, 2017 · 2 comments
Closed

Improvement of front-end of blast app #36

hsiaoyi0504 opened this issue Sep 18, 2017 · 2 comments

Comments

@hsiaoyi0504
Copy link
Member

hsiaoyi0504 commented Sep 18, 2017

Just document things can be improved in front end of blast app.

  1. use prop() rather than attr() for disabled, checked, and selected
    such as

    $('.program').attr('disabled', false).removeClass('disabled-radio');

    $('.blastp').attr('disabled', 'disabled').addClass('disabled-radio');

    It relates to performance and avoid error.

  2. Move css on template to specific css file
    such as

    <style>
    .nav-tabs>li.active>a, .nav-tabs>li.active>a:hover, .nav-tabs>li.active>a:focus {
    box-shadow: inset 0 -2px 0 #317eac;
    color: #317eac;
    border: 0px;
    }
    .txt:hover {
    text-decoration: underline;
    }
    </style>

    <legend>BLAST Databases <a href="https://i5k.nal.usda.gov/content/blast-tutorial" target="_blank"><span style="float:right"><span class="glyphicon glyphicon-book"></span> Tutorial</span></a></legend>

    <span class="load-nucleotide">Or</span> <span class="load-peptide">load</span> it from disk <span style=" cursor: pointer; font-weight:bold; color: blue;" class="load-nucleotide txt"> (load example) </span>

It will make it more easier to maintain css and avoid error.

  1. Use :disabled css selector, rather than add disabled class dynamically.
    https://developer.mozilla.org/zh-TW/docs/Web/CSS/:disabled
@hsiaoyi0504
Copy link
Member Author

It looks like that 3. :disabled css selector, rather than add disabled class dynamically. is not easy to solve. Will do this in the future if possible.

@hsiaoyi0504
Copy link
Member Author

Fixed in #91. Close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant