Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

paintkit name problem #6

Open
madlifer opened this issue Jun 3, 2017 · 4 comments
Open

paintkit name problem #6

madlifer opened this issue Jun 3, 2017 · 4 comments
Labels

Comments

@madlifer
Copy link

madlifer commented Jun 3, 2017

cant get chinese all skin name is ???

@wthueb
Copy link
Contributor

wthueb commented Jun 3, 2017

That's because it uses unicode. Fixing it would be too much of a hassle for what it is. It still says the English name in parenthesis.

@namazso
Copy link
Owner

namazso commented Jun 4, 2017

@wi1h imgui supports unicode in utf8, and the way i convert names (codecvt) from UCS2, special chars are perfectly preserved, there is just simply no font loaded for that region in imgui.

@namazso
Copy link
Owner

namazso commented Jun 4, 2017

After waiting an eternity for imgui to load GNU Unifont, both chinese and japanese characters display perfectly
pic
Unfortunately ImGui doesn't ( yet, ocornut/imgui#1010 ) allow only loading needed glyphs, and loading fonts for every language takes very long.
Until there is no better solution this is considered to work like this by design. I might push a commit later to fix Dragon King since that affects all languages.

@LonelyDreamr
Copy link

That's because it uses unicode. Fixing it would be too much of a hassle for what it is. It still says the English name in parenthesis.

I'm just used to English names of weapon skins. How should I modify the source code so that the abnormal display in Chinese could change to English names? Thanks for your help in advance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants