Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recurse if the question name matches the resolver suffix. #36

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

turbomaze
Copy link

Before

If the deployed resolver had a resolver suffix of a.b, then querying *(a.b.)+ could cause problems.

After

Instead of replacing just the suffix, we replace all ${suffix}+$. Then, in the case of a query that results in a recursive cycle, we don't bother generating an answer and just send an SOA. Another nameserver layer in front of the handshake resolver handles serving NS records for the zone, so only other question types will hit this empty response SOA.

@turbomaze turbomaze merged commit 0b207ed into production-namebase Dec 2, 2020
@turbomaze turbomaze deleted the anthony-fix-recursive-queries branch December 2, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant