Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GET /wallet/:id/ownsName/:name #42

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Add GET /wallet/:id/ownsName/:name #42

merged 2 commits into from
Jan 29, 2021

Conversation

RevCBH
Copy link

@RevCBH RevCBH commented Jan 26, 2021 •
edited
Loading

Have tested that it works on the receiving end on mainnet with drugplug/, a name that I withdrew to a local wallet from namebase. Still need to:

  • Verify that it deterministically selects an owner when both nodes have a FINALIZE
  • Figure out why it gives an empty response instead of a 404 (no repro, seems fine)

@RevCBH RevCBH force-pushed the bennetthoffman/ch3925/hsd-proxy-automate-reassigning-owner-when branch from eeac92b to 72b7a61 Compare January 26, 2021 20:27
turbomaze
turbomaze suggested changes Jan 27, 2021
View reviewed changes
Copy link

@turbomaze turbomaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops left comments not in review mode

@RevCBH RevCBH requested a review from turbomaze January 28, 2021 15:08
@RevCBH
Copy link
Author

RevCBH commented Jan 28, 2021

Bump @turbomaze

@turbomaze turbomaze merged commit bdbe86e into production-namebase Jan 29, 2021
@turbomaze turbomaze deleted the bennetthoffman/ch3925/hsd-proxy-automate-reassigning-owner-when branch January 29, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbomaze turbomaze turbomaze approved these changes

@rozaydin rozaydin Awaiting requested review from rozaydin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RevCBH @turbomaze