Ridvan rebase hsd 2.3.0 #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
account.lookahead is saved to the database as a uint8 so values larger than 255 will overflow anyway. BIP44 only recommends a gap limit of 20 anyway so this should be plenty.
Mining: set minimum block weight to 5000, parse as configuration option
txdb: fix lockedUnconfirmed if FINALIZE is inserted with block
wallet: bump lookahead to 200
test: demonstrate interactive name swaps
walletDB deepClean(): - deletes all mapping of blocks, outpoints and tx hashes to wallet ids - deletes ENTIRE txdb (all history, all balance data, for all wallets) - keeps all account metadata (account name, type, address depth, etc) - keeps all name->wallet ID mapping (although this may be unnecessary) - keeps all address-hash path mapping (addresses from all accounts) wallet HTTP /deepclean: - requires admin token, like /rescan - requires setting parameter `I_HAVE_BACKED_UP_MY_WALLET` to `true`
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
…missing 0th address Signed-off-by: rozaydin <ridvan@namebase.io>
|
I did testing on my local-end no issues i have run into, all tests are green as well. |
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
RevCBH
reviewed
Mar 1, 2021
There was a problem hiding this comment.
Looks good to me, but I'll give @turbomaze a chance to go through it before approving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested in my local setup, normal flows (open, bid, redeem, etc) are verified to be working, all unit tests are also passing.
One important point is the small hack we introduced in account.js file for lookup field. I can not foresee who this will impact existing wallets.