Ridvan batch reveal cache #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
turbomaze
suggested changes
Mar 21, 2021
lib/wallet/http.js
Outdated
| const tx = await req.wallet.sendMTX(mtx, passphrase); | ||
| return res.json(200, {tx: tx.getJSON(this.network), | ||
| errors: errorMessages}); | ||
| const revealCache = req.wallet.sendRevealResults; |
There was a problem hiding this comment.
Can you split this function up it's doing so many things so it's a bit hard to review
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
turbomaze
suggested changes
Mar 23, 2021
There was a problem hiding this comment.
Thanks for the changes, could you address all the github actions complains about JSDoc stuff and trailing whitespaces? I think this is failing the eslint rules.
Additionally, can we remove the need to update namebase-hs-client? We can have two different hsd-proxy endpoints and communicate with them over http like normal, never hitting hs-client.
|
|
||
| const revealCache = req.wallet.sendRevealResults; | ||
|
|
||
| const { cacheMisses: uniqueNames, cacheHits: processedReveals } = util |
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
turbomaze
suggested changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains batch-reveal wallet code, tested locally, including timeout testing, local tests are failing (9 of them) but it's because our production-namebase have the same tests failing.