-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requesting names UI & Functionality #371
Conversation
One observation I can make is that we must transform the invoice into a paid status after sending it |
The |
The other thing we should probably do is, make the "Check name availability..." button check whether a name_new is already in the wallet for that name (by doing the same check that the name_firstupdate command does), and if so, the UI should change to a new UI that only does name_firstupdate (as opposed to name_autoregister) -Jeremy |
I think the |
Is this the check I should be looking at For the UI, I plan to open |
Yes, that should work, do we plug it into |
Neither, AFAICT this should already work out of the box if you call |
Yes. Feel free to factor that out into a separate function.
Yes that sounds fine; we already have an autoregister and update code path there, adding a 3rd firstupdate codepath should be straightforward. |
Alright! |
If we make a separate the function, the password needs to be passed here This would mean prompting the user to enter the password for every check name availability? |
Good point, I hadn't thought of that. OK, in that case, how about you instead edit the |
This works well, definitely easier to implement |
Code review passes for f784cae other than the things I noted above. Will test shortly. |
Testing successful for f784cae other than the things I noted above. |
ACK a24ce48 |
Continuation of #363