Skip to content

Commit

Permalink
Merge bitcoin/bitcoin#29960: depends: pass verbose through to cmake b…
Browse files Browse the repository at this point in the history
…ased makefiles

7c69baf depends: pass verbose through to cmake based make (Max Edwards)

Pull request description:

  While testing bitcoin/bitcoin#29708 I was not able to enable verbose output to check which flags were being given to the compiler.

  With this PR, running depends with V=1 will enable verbose output from makefiles generated by cmake.

  How to test:

  ```shell
  make -C depends libnatpmp V=1
  ```

ACKs for top commit:
  hebasto:
    ACK 7c69baf. Tested using the folowing command:
  fanquake:
    ACK 7c69baf

Tree-SHA512: 81cd1326e940c5f14cbde96735fd02b03c1150881ed88d1e8dfa9385dfa12284bfa2cdfe097ce5f43a726c1718afb76ae16f71552ab68c207d74fdc1f7bb46ae
  • Loading branch information
fanquake committed May 6, 2024
2 parents f7b81c7 + 7c69baf commit 00ac1b9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions depends/funcs.mk
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
cmake -DCMAKE_INSTALL_PREFIX:PATH="$$($($(1)_type)_prefix)" \
-DCMAKE_INSTALL_LIBDIR=lib/ \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DCMAKE_VERBOSE_MAKEFILE:BOOL=$(V) \
$$($(1)_config_opts)
ifeq ($($(1)_type),build)
$(1)_cmake += -DCMAKE_INSTALL_RPATH:PATH="$$($($(1)_type)_prefix)/lib"
Expand Down

0 comments on commit 00ac1b9

Please sign in to comment.