Don't hide name ops sent to change addresses #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particularly matters because the name_new RPC method sends to a change address by default, so if you issued a name_new, it would never show up in the Transactions tab.
|
ACK c2b76c7. I may not be able to merge this until in a few days, though, as I'm currently not at my main computer. |
@domob1812 Is it OK if I merge this myself (via the |
|
Yes if you can then please do so, exactly with that script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particularly matters because the
name_newRPC method sends to a change address by default, so if you issued aname_new, it would never show up in the Transactions tab.