expand tab indent and typo fixes and add blocknotify command #187
+36
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add blocknotify command
|
Thanks! Is it the same implementation as in Bitcoin? |
|
Not the same. This patch comes with two additional parameters height and bits of the next block, which are key for mining the next block, in additional to blockhash. But it is compatible with bitcoin's implementation. If you do not like the additional parameters, simply remove main.cpp lines from 1526 to 1534. |
|
If I understand #198 correctly then this is still not resolved? Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-blocknotify is currently missing in namecoin