Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goxnetip should depend on goxsysunix #64

Closed
JeremyRand opened this issue Oct 2, 2019 · 1 comment · Fixed by #65
Closed

goxnetip should depend on goxsysunix #64

JeremyRand opened this issue Oct 2, 2019 · 1 comment · Fixed by #65

Comments

@JeremyRand
Copy link
Member

JeremyRand commented Oct 2, 2019 •
edited

Steps to reproduce

  1. Checkout tor-browser-build Git commit hash 177afba4be247dd88d089d7f5e769625003a181c.
  2. Add ncdns-repro Git commit hash cafb2b1 as a Git submodule of tor-browser-build.
  3. Build goxnetip for GNU/Linux x86_64.

Expected results

goxnetip should build without errors.

Observed results

cannot find package "golang.org/x/sys/unix"

Other notes

Adding goxsysunix as a dependency of goxnetip should fix the issue.
@JeremyRand
Copy link
Member Author

The relevant code is at https://github.com/golang/net/blob/fa69b94a3b58e78ecdde45ef38891b5026a9f8a6/internal/socket/sys_const_unix.go . Looks like socket depends on goxsysunix on Darwin and Linux (all arches). According to https://github.com/golang/net/blob/1f3472d942ba824034fb77cab6a6cfc1bc8a2c3c/ipv6/control_rfc3542_unix.go , goxnetip depends on socket on both of those OS's as well.

JeremyRand added a commit to JeremyRand/ncdns-repro that referenced this issue Oct 2, 2019
@JeremyRand
(WIP) goxnetip: Add goxsysunix dependency for macOS/Linux
098fa0a 
Fixes namecoin#64

TODO: Untested.
@JeremyRand JeremyRand mentioned this issue Oct 2, 2019
Merged
JeremyRand added a commit that referenced this issue Oct 3, 2019
@JeremyRand
Merge #65: goxnetip: Add goxsysunix dependency for macOS/Linux
316fea5 
8a543d3 goxnetip: Add goxsysunix dependency for macOS/Linux (JeremyRand)

Pull request description:

  Fixes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

goxnetip: Add goxsysunix dependency for macOS/Linux JeremyRand/ncdns-repro
1 participant
@JeremyRand