Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS builds #23

Merged
merged 1 commit into from Jun 18, 2019
Merged

Fix macOS builds #23

merged 1 commit into from Jun 18, 2019

Conversation

JeremyRand
Copy link
Member

This PR fixes the build errors for the release-osx-x86_64 target.

@JeremyRand
Copy link
Member Author

If anyone wants to test the resulting binaries without building from source, here's a binary I just built:

http://zs7xwvcspvnnrqhvyxyxpjkihc4lva3yustfr75j6giy24mdfg3rcwqd.onion/#DW9QDpGmdLLwQAw9f4MmZQ

SHA256 hash is ec79f6ce5eaaad0f84a3b116e93ed22b0bc93b61abc73a9e70a501d37880a11c.

@JeremyRand
Copy link
Member Author

For anyone who wants to test the binaries with both this PR and #26 applied, here's a binary:

http://zs7xwvcspvnnrqhvyxyxpjkihc4lva3yustfr75j6giy24mdfg3rcwqd.onion/#gtITR1ys2EJ6hFAQUfgLFw

SHA256 hash is 6a4d4ffe0d8dafa69fdc9815933f6f1856eaacc732bcaac2b45d25c2e83c926a.

@JeremyRand JeremyRand mentioned this pull request Jun 10, 2019
Merged
2 tasks
@JeremyRand
Copy link
Member Author

@hlandau This PR (as well as #26 and #27 ) will be merged in 1 week if I don't hear anything from you on the subject.

@cojapacze
Copy link

cojapacze commented Jun 11, 2019 •
edited

http://zs7xwvcspvnnrqhvyxyxpjkihc4lva3yustfr75j6giy24mdfg3rcwqd.onion/#gtITR1ys2EJ6hFAQUfgLFw

SHA256 hash is 6a4d4ffe0d8dafa69fdc9815933f6f1856eaacc732bcaac2b45d25c2e83c926a.

ncdns binary tested on macOS Mojave 10.14.5 with success.

@JeremyRand JeremyRand merged commit e0bca81 into namecoin:master Jun 18, 2019
JeremyRand added a commit that referenced this pull request Jun 18, 2019
@JeremyRand
Merge #23: Fix macOS builds
8ffc0cb 
e0bca81 Fix macOS builds (JeremyRand)

Pull request description:

  This PR fixes the build errors for the `release-osx-x86_64` target.
JeremyRand added a commit that referenced this pull request Jul 30, 2019
@JeremyRand
Merge #28: Add ncp11 project and its dependencies
732585f 
a503c1b Add ncp11 project (JeremyRand)
6f34bbd Add namecoin/pkcs11mod project (JeremyRand)
0ee2b0e Add miekg/pkcs11 project (JeremyRand)

Pull request description:

  Fixes #10 .  Fixes #16 .

  ~~Only tested on GNU/Linux targets.  Windows definitely won't work yet due to an ncp11/pkcs11mod bug that's out of scope for this PR.~~  GNU/Linux and Windows now both work.  macOS is untested.

  TODO:

  - [x] Merge #23 first (this PR will then need a rebase).
  - [x] Finalize the commits marked (WIP).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeremyRand @cojapacze