Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ #106

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ #106

merged 1 commit into from
Oct 28, 2019

Conversation

JeremyRand
Copy link
Member

@JeremyRand JeremyRand commented Aug 1, 2019 •
edited
Loading

Fixes #105

TODO:

@JeremyRand JeremyRand changed the title Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ (WIP Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ Aug 2, 2019
@JeremyRand JeremyRand changed the title (WIP Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ (WIP) Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ Aug 2, 2019
@JeremyRand JeremyRand force-pushed the conformal-rpcclient-ncdumpzone-loop branch from 143edb2 to 40bb8b6 Compare August 2, 2019 05:21
@JeremyRand
Copy link
Member Author

Fixed merge conflict.

@JeremyRand JeremyRand force-pushed the conformal-rpcclient-ncdumpzone-loop branch from 40bb8b6 to c4f3a4c Compare August 2, 2019 05:35
@JeremyRand JeremyRand force-pushed the conformal-rpcclient-ncdumpzone-loop branch from c4f3a4c to b74794a Compare October 27, 2019 16:34
@JeremyRand JeremyRand changed the title (WIP) Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+ Oct 27, 2019
@JeremyRand JeremyRand mentioned this pull request Oct 27, 2019
Open
@JeremyRand
ncdumpzone: Work around encoding errors
539bc89 
Namecoin Core 0.18.0+ now reports an empty Name with a non-empty NameError
when an encoding error was encountered.  This was causing an infinite loop
in ncdumpzone.

Fixes namecoin#105
@JeremyRand JeremyRand force-pushed the conformal-rpcclient-ncdumpzone-loop branch from b74794a to 539bc89 Compare October 27, 2019 19:37
JeremyRand added a commit that referenced this pull request Oct 28, 2019
@JeremyRand
Merge #106: Fix infinite loop in ncdumpzone with Namecoin Core 0.18.0+
7c39b77 
539bc89 ncdumpzone: Work around encoding errors (JeremyRand)

Pull request description:

  Fixes #105

  TODO:

  - [x] Merge #103 (this PR will then need a rebase)

ACKs for commit 539bc8:

Tree-SHA512: 5762687077ea2611cd7939dd49d337346b212a91442b32f7be5ac592e2580029bc0e63c4e6597b2685495de59a431fe422048fc3a1f0d52fb678e377eb947401
@JeremyRand JeremyRand merged commit 539bc89 into namecoin:master Oct 28, 2019
@JeremyRand JeremyRand deleted the conformal-rpcclient-ncdumpzone-loop branch December 25, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ncdumpzone infinite loop in Namecoin Core 0.18.0
1 participant
@JeremyRand