Add no_namecoin_tls build tag #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
force-pushed
the
tls-optional
branch
6 times, most recently
from
106fae1
to
3ffa096
Compare
JeremyRand
force-pushed
the
tls-optional
branch
from
39fdcb5
to
0e63698
Compare
1 task
JeremyRand
added a commit
that referenced
this pull request
Oct 4, 2019
0e63698 Add no_namecoin_tls build tag (JeremyRand) Pull request description: This PR allows building ncdns without TLSA record support. Doing so decreases the binary size and attack surface significantly. ACKs for commit 0e6369: Tree-SHA512: 84ab2a36ab2931e40d6511997ba7f06a0b66d9773dba8002f3044abd21da5729a6d9239042be74a86a23c18678b83edc80e8d105045ca787af88c495a0856d8d
JeremyRand
added a commit
to namecoin/ncdns-repro
that referenced
this pull request
Oct 19, 2019
c9fcdaa ncprop279: Support disabling TLSA (JeremyRand) 89ff49a ncdns: Disable TLSA dependencies when TLSA is disabled (JeremyRand) 6aa54c3 ncdns: Support disabling TLSA (JeremyRand) Pull request description: This PR exposes namecoin/ncdns#115 as an rbm target. TODO: - [x] Reduce dependencies accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows building ncdns without TLSA record support. Doing so decreases the binary size and attack surface significantly.