Travis: various static analysis fixes/improvements #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
force-pushed
the
static-analysis-goimports
branch
from
6a2ad20
to
7fc0fe8
Compare
JeremyRand
force-pushed
the
static-analysis-goimports
branch
from
751181c
to
c1f6d2c
Compare
JeremyRand
changed the title
JeremyRand
changed the title
|
Ready for review. |
|
ACK c1f6d2c |
JeremyRand
added a commit
that referenced
this pull request
Jun 27, 2018
c1f6d2c ncdomain: fix redundant return statement in parseSingleService. (JeremyRand) a876b17 ncdomain: fix redundant return statement in parseSingleMX. (JeremyRand) 40eeed1 ncdomain: fix redundant return statement in parseTXT. (JeremyRand) 497faca goimports -w tlsrestrictchromium/tlsrestrict_chromium_tool/main.go (JeremyRand) a107d33 goimports -w tlsrestrictchromium/chromium_test.go (JeremyRand) 056215e Travis: mark megacheck linter as non-critical. (JeremyRand) 91e1ce4 Travis: aligncheck linter is replaced by maligned linter. (JeremyRand) cf97a1a Travis: mark nakedret linter as non-critical. (JeremyRand) f031d2b goimports -w tlsrestrictchromium/chromium.go (JeremyRand) 5350011 Travis: update gometalinter to v2. (JeremyRand) 9b6643d goimports -w server/server.go (JeremyRand) 4c66b15 certinject: Fix duplicated log variable. (JeremyRand) 5d508f6 goimports -w certdehydrate/certdehydrate_test.go (JeremyRand) 519f47f goimports -w main.go (JeremyRand) Pull request description: TODO: - [x] Fix any static analysis warnings that this triggers. Tree-SHA512: 4071af04fa08534815b8d14fccc998087d9d9580b2407bea0671e290e370a5e75d608a21d351b7377387e0f4029f870049feaa0adeaef0e99fa3252eef272df7
JeremyRand
added a commit
that referenced
this pull request
Aug 7, 2018
9496034 Travis: disable gofmt linter. (JeremyRand) 99cb7d9 Travis: enable goimports static analyzer as critical. (JeremyRand) Pull request description: Depends on #54 and #77 . Should be mergeable after those are merged, assuming Travis passes at that point. Tree-SHA512: 174fc0d5b0bd5734703d4e97d04d70389883071fec41436ef6a93b543e449032db8faab2ab0a3b287a3c180504e3a2e64d446c613cc4643016c90e13a4744c7a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: