Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQP refactor [remove queue consumer] #578

Merged
merged 105 commits into from
Oct 2, 2018
Merged

AMQP refactor [remove queue consumer] #578

merged 105 commits into from
Oct 2, 2018

Conversation

mattbennett
Copy link
Member

Merging #542 into v3 release candidate branch

@mattbennett
split header encoding/decoding logic out into functions
94d3943
@mattbennett
checkout: simplify methodproxy by not passing worker_ctx in
82d2e7d
@mattbennett
checkpoint: avoid passing things down through the chain by using a pa…
d7a6a3f 
…rtial
@mattbennett
minor tidyup and consistency
f015866
@mattbennett
checkpoint: standalone rpc proxy reimplemented without "queue consumer"
0215319
@mattbennett
restore call stack and timeout implementation
5838c66
@mattbennett
test cleanup: proxy retries instead of throwing on connection errors
e4537e9
@mattbennett
test cleanup: we now attempt to reconnect forever rather than throwin…
aa56d09 
…g on

the second failure
@mattbennett
test cleanup: consumeevent no longer exists
2367ac8
@mattbennett
test cleanup: we don't explicitly manage consumers anymore
5dbdb73
@mattbennett
test cleanup: reply listener disconnection is now very similar to rpc
2f9241d 
consumer disconnection
@mattbennett
longer expiries to ensure queue sticks around until we consume from it
4b96c2c
@mattbennett
pyflakes
ab534ef
@mattbennett
additional test coverage for rpc requests longer than reply queue tim…
dfdb417 
…eouts
@mattbennett
additional test for stopping and restarting standalone proxy
2b86cc1
@mattbennett
new feature: use uuid of the standalone proxy in its call stack
1d04e81
@mattbennett
small refactor to pass queue into reply listener
c0537d6
@mattbennett
toxiproxy controller removed "reset" function
237a276
@mattbennett
add support for raising if reply queue expires with pending replies
6f6182a 
now that the implementation supports it (standalone rpc proxy case)
@mattbennett
import sort
4c4f4f3
@mattbennett
unused import
825d273
@mattbennett
split header encoding/decoding logic out into functions
d07de86
@mattbennett
additional test coverage for rpc requests longer than reply queue tim…
8772717 
…eouts
@mattbennett
introduce "proxy" class replacing ServiceProxy and MethodProxy
0b6d613
@mattbennett
squash ServiceProxy and MethodProxy into one object; simplify ReplyLi…
3495428 
…stener
@mattbennett
unit test coverage for Proxy object
4570ff8
@mattbennett
refactor: simplify Proxy object by passing only get_reply rather than…
1a2bd13 
… whole

reply listener
@mattbennett
add full publisher "options" to standalone proxy
046a776
@mattbennett
remove remaining deprecations ahead of 2.9.0
0f9b4ad
@mattbennett
remove unused helpers
e2ab58f
@mattbennett
import sort
990213a
@mattbennett
more cleanup: remove unnecessary serializer attrs
c6f6cbe 
and the incorrect comment referring to kombu
@mattbennett
can drop the complex fixture re-ordering now that
0c33a12 
we don't wait for consumers to close gracefully
on kill (this has been fine since we started using
a vhost per test)
@mattbennett
add tests for new Consumer core
e94e76d
@mattbennett
DRY out temporary fixture by moving it to conftest
b14f5ea
@mattbennett
add tests for container being killed to
af9fe23 
publisher and event dispatcher
@mattbennett
replace existing rpc test for container being killed
2799115 
with one following the same pattern as other entrypoints
@mattbennett
fix import
c865809
@mattbennett
don't need to do this because consumer.run just
bdeea19 
executes in a managed thread; already tested elsewhere
@mattbennett
fix imports
903a9d0
@mattbennett
no cover pragmas
c07e704
@mattbennett
tiny bit more cleanup: pass options to publisher earlier
04d2fcb
@mattbennett
serializer arg not used by consumer
c527986
@mattbennett
rename "options" to "publisher_options"
c9e7615
@mattbennett
import sort
b414931
@mattbennett
tests for stopping consumers with active workers
7d7f160
@mattbennett
accept consumer options in amqp consuming extensions
0a0abe0 
(except rpc, because they all share a consumer)
@mattbennett
add autodoc'd modules so we check spelling
68c53fb
@mattbennett
spelling fixes
52287c1
@mattbennett
restore AUTO_FIX_IMPORTS
f41258b
@mattbennett
remove HeaderEncoder, HeaderDecoder classes
80184b1
@mattbennett
serialization.setup() returning namedtuple
fb4430e
@mattbennett
add comment explaining why we have to use a background thread
f64a6c3 
to wait on the worker pool
@mattbennett
be more explicit determining target service/method
25e6ebb
@mattbennett
speak like yoda i do
4298432
@mattbennett
Merge remote-tracking branch 'upstream/master' into remove-queue-cons…
096a57f 
…umer
@mattbennett
upgrade moto (nameko#577)
33ca58f
@mattbennett
Merge remote-tracking branch 'upstream/master' into remove-queue-cons…
4a4b31d 
…umer
@mattbennett mattbennett merged commit 8791efd into nameko:v3.0.0-rc Oct 2, 2018
@mattbennett mattbennett mentioned this pull request Oct 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattbennett