Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update composer.json to reflect required extensions and minimum PHP v… #38

Merged
merged 1 commit into from Jul 26, 2015
Merged

update composer.json to reflect required extensions and minimum PHP v… #38

merged 1 commit into from Jul 26, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2015

…ersion as found by phpcompatinfo

@cirpo
Copy link
Contributor

cirpo commented Jul 23, 2015

@fkooman sorry I missed this PR, going to check asap. thanks

@odino
Copy link
Contributor

odino commented Jul 26, 2015

hey @fkooman how did you generate the chages on the composer.json?

@ghost
Copy link
Author

ghost commented Jul 26, 2015

@odino using http://php5.laurent-laville.org/compatinfo/ PHP CompatInfo (yum install php-bartlett-PHP-CompatInfo)

@cirpo
Copy link
Contributor

cirpo commented Jul 26, 2015

@fkooman wow, thanks!

@odino
Copy link
Contributor

odino commented Jul 26, 2015

👍

odino added a commit that referenced this pull request Jul 26, 2015
update composer.json to reflect required extensions and minimum PHP v…
@odino odino merged commit d0fc315 into namshi:master Jul 26, 2015
@cirpo
Copy link
Contributor

cirpo commented Jul 26, 2015

@odino so we decided to go with PHP ">=5.4.8"? I didn't merge this PR because the discussion is still open here: #39

@odino
Copy link
Contributor

odino commented Jul 26, 2015

@cirpo I actually checked if PHP 5.3 was still supported and it isnt, so I think it's not a big deal to require people to use a reasonably mdern version of php. I think, though, that we should change the major release in the next tag so that people do not get confused / screwed

@cirpo
Copy link
Contributor

cirpo commented Jul 26, 2015

👍

@ghost
Copy link
Author

ghost commented Jul 26, 2015

According to phpcompatinfo the only reason why PHP 5.3 is not supported anymore is the use of the (new) OpenSSL constants (see them listed in #39) only available since 5.4.8 and the use of hash_equals (since 5.6.0beta1, but a wrapper exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants