Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #33 #50

Closed
wants to merge 3 commits into from
Closed

Issue #33 #50

wants to merge 3 commits into from

Conversation

daleattree
Copy link

Ensured iat is an integer as specified in issue #33

@@ -1,2 +1,3 @@
vendor/
build/
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daleattree ide / platform / specific os files should be in your global gitignore, not in the project repo

@cirpo
Copy link
Contributor

cirpo commented Oct 27, 2015

@daleattree thanks for the PR, would you mind to fix the .gitignore?

This reverts commit 0cd0af8.
@daleattree
Copy link
Author

.gitignore has been fixed. Apologies for that.

@odino
Copy link
Contributor

odino commented Nov 4, 2015

What will happen when trying to verify an old token with this new version? I think casting will automatically happen but can we add a test for that? :)

@cirpo
Copy link
Contributor

cirpo commented Nov 13, 2015

@daleattree any updates? When you're done with the test, could you also please squash everything in one commit? thanks

@daleattree
Copy link
Author

Sorry. Been a bit hectic at work. Will try and get the test done over the weekend.

@cirpo
Copy link
Contributor

cirpo commented Nov 13, 2015

@daleattree no need to be sorry, thanks for your effort! If you don't have time just let me know, we can help :)

@cirpo
Copy link
Contributor

cirpo commented Dec 6, 2015

@daleattree hi, If it's fine for you I will jump on this this week, updating the tests, in order to merge these changes. ok?

@daleattree
Copy link
Author

Yes please.

On Sun, Dec 6, 2015 at 8:00 AM, cirpo notifications@github.com wrote:

@daleattree https://github.com/daleattree hi, If it's fine for you I
will jump on this this week, updating the tests, in order to merge these
changes. ok?


Reply to this email directly or view it on GitHub
#50 (comment).

@cirpo
Copy link
Contributor

cirpo commented Dec 9, 2015

@daleattree check #60 thanks

@cirpo cirpo closed this Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants