-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #33 #50
Issue #33 #50
Conversation
@@ -1,2 +1,3 @@ | |||
vendor/ | |||
build/ | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daleattree ide / platform / specific os files should be in your global gitignore, not in the project repo
@daleattree thanks for the PR, would you mind to fix the .gitignore? |
This reverts commit 0cd0af8.
.gitignore has been fixed. Apologies for that. |
What will happen when trying to verify an old token with this new version? I think casting will automatically happen but can we add a test for that? :) |
@daleattree any updates? When you're done with the test, could you also please squash everything in one commit? thanks |
Sorry. Been a bit hectic at work. Will try and get the test done over the weekend. |
@daleattree no need to be sorry, thanks for your effort! If you don't have time just let me know, we can help :) |
@daleattree hi, If it's fine for you I will jump on this this week, updating the tests, in order to merge these changes. ok? |
Yes please. On Sun, Dec 6, 2015 at 8:00 AM, cirpo notifications@github.com wrote:
|
@daleattree check #60 thanks |
Ensured iat is an integer as specified in issue #33