Move isExpired from SimpleJWS to JWS #91
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this change in order to be able to check if a JWS created from an instance of
Namshi\JOSE\JWS
is expired or not (and not only from SimpleJWS), sort as we can do the check even if using the SecLib encryption engine.Or is there something in the method that is not directly compatible with the JWS class, or that doesn't make sense to exist into?
ATM I need to duplicate the isExpired method in my project to do this chek on
Namshi\JOSE\JWS
instances.