Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winston v3 compatible #5

Merged
merged 1 commit into from
Jul 16, 2018
Merged

winston v3 compatible #5

merged 1 commit into from
Jul 16, 2018

Conversation

cybuhh
Copy link
Contributor

@cybuhh cybuhh commented Jul 16, 2018 •
edited
Loading

  • dependencies update
  • winston v3 compatible
  • remove lodash in favour of native ECMAScript

@cybuhh cybuhh changed the title dependencies update, winston v3 compatible, remove lodash in favour o… winston v3 compatible Jul 16, 2018
@cybuhh cybuhh mentioned this pull request Jul 16, 2018
Closed
odino
odino reviewed Jul 16, 2018
View reviewed changes
Copy link
Contributor

@odino odino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question -- does NR not support the getBrowserTimingHeader thing anymore?

@cybuhh
Copy link
Contributor Author

cybuhh commented Jul 16, 2018

sorry my bad, getBrowserTimingHeader is back in the code

@odino odino merged commit c6e420a into namshi:master Jul 16, 2018
@odino
Copy link
Contributor

odino commented Jul 16, 2018

in v2.0.0

@cybuhh cybuhh deleted the v3-compatibile branch July 16, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odino odino odino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cybuhh @odino