scripts: Code cosmetics

install.sh

@@ -15,7 +15,7 @@ GS_VERSIONS=('3.18' '3.24' '3.26' '3.28' '3.30')
 LATEST_GS_VERSION="${GS_VERSIONS[-1]}"
 
 # Set a proper gnome-shell theme version
-if command -v gnome-shell >/dev/null ; then
+if command -v gnome-shell >/dev/null; then
   CURRENT_GS_VERSION="$(gnome-shell --version | cut -d ' ' -f 3 | cut -d . -f -2)"
   for version in "${GS_VERSIONS[@]}"; do
     if (( "$(bc <<< "$CURRENT_GS_VERSION <= $version")" )); then
@@ -126,7 +126,7 @@ install_gdm() {
   local GS_THEME_FILE="/usr/share/gnome-shell/gnome-shell-theme.gresource"
   local UBUNTU_THEME_FILE="/usr/share/gnome-shell/theme/ubuntu.css"
 
-  if [[ -f "$GS_THEME_FILE" ]] && command -v glib-compile-resources >/dev/null ; then
+  if [[ -f "$GS_THEME_FILE" ]] && command -v glib-compile-resources >/dev/null; then
     echo "Installing '$GS_THEME_FILE'..."
     cp -an "$GS_THEME_FILE" "$GS_THEME_FILE.bak"
     glib-compile-resources \

render-assets.sh

@@ -7,11 +7,11 @@ if [[ ! "$(command -v inkscape || command -v rendersvg)" ]]; then
 fi
 
 if [[ ! "$(command -v optipng)" ]]; then
-  echo "'optipng' needs to be installed to optimize the resulting PNG!"
+  echo "'optipng' needs to be installed to optimize the resulting PNG."
 fi
 
 chrome() (
-  cd ./src/chrome
+  cd src/chrome
   ./render-assets.sh
 )
 

src/chrome/render-asset.sh

@@ -8,12 +8,12 @@ OPTIPNG="$(command -v optipng)" || true
 i="$1"
 
 echo "Rendering '$i.png'"
-if [[ -n "${RENDER_SVG}" ]] ; then
+if [[ -n "${RENDER_SVG}" ]]; then
   "$RENDER_SVG" --dpi 96 "$i.svg" "$i.png"
 else
   "$INKSCAPE" --export-dpi=96 --export-png="$i.png" "$i.svg" >/dev/null
 fi
 
-if [[ -n "${OPTIPNG}" ]] ; then
-	"$OPTIPNG" -o7 --quiet "$i.png"
+if [[ -n "${OPTIPNG}" ]]; then
+  "$OPTIPNG" -o7 --quiet "$i.png"
 fi

src/chrome/render-assets.sh

@@ -3,7 +3,7 @@ set -ueo pipefail
 
 # Make sure that parallel is GNU parallel and not moreutils.
 # Otherwise, it fails silently. There's no smooth way to detect this.
-if command -v parallel >/dev/null ; then
+if command -v parallel >/dev/null; then
   cmd=(parallel)
 else
   cmd=(xargs -n1)

src/gtk-2.0/render-asset.sh

@@ -17,7 +17,7 @@ i="$2"
 
 # @TODO: remove $ZOOM when it will be fixed/implemented in resvg
 GTK2_HIDPI="$(echo "${GTK2_HIDPI-False}" | tr '[:upper:]' '[:lower:]')"
-if [[ "${GTK2_HIDPI}" == "true" ]] ; then
+if [[ "${GTK2_HIDPI}" == "true" ]]; then
   DPI=192
   ZOOM=2
 else
@@ -26,19 +26,19 @@ else
 fi
 
 echo "Rendering '$ASSETS_DIR/$i.png'"
-if [[ -n "${RENDER_SVG}" ]] ; then
-	# @TODO: remove --zoom when it will be fixed/implemented in resvg
+if [[ -n "${RENDER_SVG}" ]]; then
+  # @TODO: remove --zoom when it will be fixed/implemented in resvg
   "$RENDER_SVG" --export-id "$i" \
-        --dpi ${DPI} \
-        --zoom ${ZOOM} \
-         "$SRC_FILE" "$ASSETS_DIR/$i.png"
+                --dpi ${DPI} \
+                --zoom ${ZOOM} \
+                "$SRC_FILE" "$ASSETS_DIR/$i.png"
 else
   "$INKSCAPE" --export-id="$i" \
-        --export-id-only \
-        --export-dpi=${DPI} \
-        --export-png="$ASSETS_DIR/$i.png" "$SRC_FILE" >/dev/null
+              --export-id-only \
+              --export-dpi=${DPI} \
+              --export-png="$ASSETS_DIR/$i.png" "$SRC_FILE" >/dev/null
 fi
 
-if [[ -n "${OPTIPNG}" ]] ; then
-	"$OPTIPNG" -o7 --quiet "$ASSETS_DIR/$i.png"
+if [[ -n "${OPTIPNG}" ]]; then
+  "$OPTIPNG" -o7 --quiet "$ASSETS_DIR/$i.png"
 fi

src/gtk-2.0/render-assets.sh

@@ -3,7 +3,7 @@ set -ueo pipefail
 
 # Make sure that parallel is GNU parallel and not moreutils.
 # Otherwise, it fails silently. There's no smooth way to detect this.
-if command -v parallel >/dev/null ; then
+if command -v parallel >/dev/null; then
   cmd=(parallel)
 else
   cmd=(xargs -n1)

src/gtk/render-asset.sh

@@ -11,31 +11,31 @@ ASSETS_DIR="assets"
 i="$1"
 
 echo "Rendering '$ASSETS_DIR/$i.png'"
-if [[ -n "${RENDER_SVG}" ]] ; then
+if [[ -n "${RENDER_SVG}" ]]; then
   "$RENDER_SVG" --export-id "$i" \
-         "$SRC_FILE" "$ASSETS_DIR/$i.png"
+                "$SRC_FILE" "$ASSETS_DIR/$i.png"
 else
   "$INKSCAPE" --export-id="$i" \
-        --export-id-only \
-        --export-png="$ASSETS_DIR/$i.png" "$SRC_FILE" >/dev/null
+              --export-id-only \
+              --export-png="$ASSETS_DIR/$i.png" "$SRC_FILE" >/dev/null
 fi
-if [[ -n "${OPTIPNG}" ]] ; then
-	"$OPTIPNG" -o7 --quiet "$ASSETS_DIR/$i.png"
+if [[ -n "${OPTIPNG}" ]]; then
+  "$OPTIPNG" -o7 --quiet "$ASSETS_DIR/$i.png"
 fi
 
 echo "Rendering '$ASSETS_DIR/$i@2.png'"
-if [[ -n "${RENDER_SVG}" ]] ; then
-	# @TODO: remove --zoom when it will be fixed/implemented in resvg
+if [[ -n "${RENDER_SVG}" ]]; then
+  # @TODO: remove --zoom when it will be fixed/implemented in resvg
   "$RENDER_SVG" --export-id "$i" \
-        --dpi 192 \
-        --zoom 2 \
-         "$SRC_FILE" "$ASSETS_DIR/$i@2.png"
+                --dpi 192 \
+                --zoom 2 \
+                "$SRC_FILE" "$ASSETS_DIR/$i@2.png"
 else
   "$INKSCAPE" --export-id="$i" \
-        --export-id-only \
-        --export-dpi=192 \
-        --export-png="$ASSETS_DIR/$i@2.png" "$SRC_FILE" >/dev/null
+              --export-id-only \
+              --export-dpi=192 \
+              --export-png="$ASSETS_DIR/$i@2.png" "$SRC_FILE" >/dev/null
 fi
-if [[ -n "${OPTIPNG}" ]] ; then
-	"$OPTIPNG" -o7 --quiet "$ASSETS_DIR/$i@2.png"
+if [[ -n "${OPTIPNG}" ]]; then
+  "$OPTIPNG" -o7 --quiet "$ASSETS_DIR/$i@2.png"
 fi

src/gtk/render-assets.sh

@@ -3,7 +3,7 @@ set -ueo pipefail
 
 # Make sure that parallel is GNU parallel and not moreutils.
 # Otherwise, it fails silently. There's no smooth way to detect this.
-if command -v parallel >/dev/null ; then
+if command -v parallel >/dev/null; then
   cmd=(parallel)
 else
   cmd=(xargs -n1)

test.sh

@@ -25,7 +25,7 @@ GS_VERSIONS=('3.18' '3.24' '3.26' '3.28' '3.30')
 LATEST_GS_VERSION="${GS_VERSIONS[-1]}"
 
 # Set a proper gnome-shell theme version
-if command -v gnome-shell >/dev/null ; then
+if command -v gnome-shell >/dev/null; then
   CURRENT_GS_VERSION="$(gnome-shell --version | cut -d ' ' -f 3 | cut -d . -f -2)"
   for version in "${GS_VERSIONS[@]}"; do
     if (( "$(bc <<< "$CURRENT_GS_VERSION <= $version")" )); then