[regression] Problem with some gtk2 assets (combobox, entries)

[actionless]

Reporter Info

• Materia version: v20200320-83-g6f7e51a9
• GTK2 version: 2.24.32-2
• Distribution (and version): git
• Desktop environment (and version): none
• Related application (and version): awf-gtk2

Actual Issue

Steps to Reproduce
run render-assets.sh and install.sh

[afraidofmusic]

I had the same problem before but e766f45 fixed it. It might cause a regression for you if your Inkscape is old. What is the version of your Inkscape?

[actionless]

in that case it would be some image generation error in the log and also other assets generated correctly, so i think it might me some issue with elements themselves in assets.svg

[nana-4]

So sorry for the late reply on this.

I also can't reproduce this with Inkscape 1.0 (4035a4fb49, 2020-05-01) on Fedora 32.

What version of Inkscape are you using?

I tried validating src/gtk-2.0/assets.svg with https://validator.w3.org, but didn't find errors that could be related to this issue.

[nana-4]

This could be related to the HiDPI option, I guess?

Looking at your screenshot, some assets are 200% scale, but some others are 100% scale, apparently.

[actionless]

no, it's not related to hidpi

thanks for the hint -- i've double-checked with inkscape -- so apparently the issue somehow related to resvg, looking further into it

[nana-4]

Looking at your screenshot, some assets are 200% scale, but some others are 100% scale, apparently.

Oh, no, please ignore this. I didn't carefully check the screenshot, and all the assets seems 100% scale. Sorry 😓

[actionless]

so i've checked the problem is reproducing with resvg 0.5, 0.6, 0.8, 0.9 and 0.11 (and first two were known to work fine before)

so it must be smth changed in gtk2 assets file itself, mb added some new svg property which never was supported (or always was broken) in resvg

[actionless]

unfortunately i can't check the older releases of materia as they're not compiling due to sass standard breakage in sass minor release:

[actionless]

and with hidpi it looks the same, only combobox and entry looks broken:

[actionless]

so i suspect this commit but can't test it due to the sass build problem above: ff16cb5#diff-96d139dfb99fcb8d87ff483d9d92991c

[actionless]

let's try to analyze the difference between the same asset (https://github.com/nana-4/materia-theme/blob/master/src/gtk-2.0/assets.svg) rendered by inkscape vs resvg, cc @RazrFalcon

id=combo-left-entry-active

inkscape (20x20px)

resvg (38x40px), asset itself rendered in 20x20, but have extra whitespace at the right-bottom

[RazrFalcon]

Interesting. Inkscape provides the size after clipping, while resvg returns the actual size. Not sure which one is the correct one. Especially since I don't understand how exactly Inkscape does this. It's fine for rectangular clipping, but a complex one is way more tricky. Will test it later.

In the end, resvg produces an expected result here. It's not a bug. At least at a first glance.