Skip to content

Commit

Permalink
Category::level -> Category::hierarchy
Browse files Browse the repository at this point in the history
  • Loading branch information
nanasess committed Sep 26, 2017
1 parent 29abdba commit 411def6
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 26 deletions.
6 changes: 3 additions & 3 deletions src/Eccube/Controller/Admin/Product/CategoryController.php
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@ public function index(Application $app, Request $request, $parent_id = null, $id
$TargetCategory = new \Eccube\Entity\Category();
$TargetCategory->setParent($Parent);
if ($Parent) {
$TargetCategory->setLevel($Parent->getLevel() + 1);
$TargetCategory->setHierarchy($Parent->getHierarchy() + 1);
} else {
$TargetCategory->setLevel(1);
$TargetCategory->setHierarchy(1);
}
}

Expand All @@ -139,7 +139,7 @@ public function index(Application $app, Request $request, $parent_id = null, $id
if ($request->getMethod() === 'POST') {
$form->handleRequest($request);
if ($form->isValid()) {
if ($this->appConfig['category_nest_level'] < $TargetCategory->getLevel()) {
if ($this->appConfig['category_nest_level'] < $TargetCategory->getHierarchy()) {
throw new BadRequestHttpException('リクエストが不正です');
}
log_info('カテゴリ登録開始', array($id));
Expand Down
6 changes: 3 additions & 3 deletions src/Eccube/Controller/Admin/Product/CsvImportController.php
Original file line number Diff line number Diff line change
Expand Up @@ -582,12 +582,12 @@ public function csvCategory(Application $app, Request $request)

$Category->setParent($ParentCategory);
if ($ParentCategory) {
$Category->setLevel($ParentCategory->getLevel() + 1);
$Category->setHierarchy($ParentCategory->getHierarchy() + 1);
} else {
$Category->setLevel(1);
$Category->setHierarchy(1);
}

if ($this->appConfig['category_nest_level'] < $Category->getLevel()) {
if ($this->appConfig['category_nest_level'] < $Category->getHierarchy()) {
$this->addErrors(($data->key() + 1) . '行目のカテゴリが最大レベルを超えているため設定できません。');
return $this->render($app, $form, $headers);
}
Expand Down
18 changes: 9 additions & 9 deletions src/Eccube/Entity/Category.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function getPath()

public function getNameWithLevel()
{
return str_repeat(' ', $this->getLevel() - 1) . $this->getName();
return str_repeat(' ', $this->getHierarchy() - 1) . $this->getName();
}

public function getDescendants()
Expand Down Expand Up @@ -171,7 +171,7 @@ public function hasProductCategories()
*
* @ORM\Column(name="hierarchy", type="integer")
*/
private $level;
private $hierarchy;

/**
* @var int
Expand Down Expand Up @@ -275,27 +275,27 @@ public function getName()
}

/**
* Set level.
* Set hierarchy.
*
* @param int $level
* @param int $hierarchy
*
* @return Category
*/
public function setLevel($level)
public function setHierarchy($hierarchy)
{
$this->level = $level;
$this->hierarchy = $hierarchy;

return $this;
}

/**
* Get level.
* Get hierarchy.
*
* @return int
*/
public function getLevel()
public function getHierarchy()
{
return $this->level;
return $this->hierarchy;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,14 @@ private function newTestCategory($TestCreator, $TestParentCategory = null)
if ($TestParentCategory == null) {
$TestCategory->setName('テスト家具')
->setRank(100)
->setLevel(100)
->setHierarchy(100)
->setDelFlg(false)
->setParent($TestParentCategory)
->setCreator($TestCreator);
} else {
$TestCategory->setName($TestParentCategory->getName() . '_c')
->setRank($TestParentCategory->getRank() + 1)
->setLevel($TestParentCategory->getLevel() + 1)
->setHierarchy($TestParentCategory->getHierarchy() + 1)
->setDelFlg(false)
->setParent($TestParentCategory)
->setCreator($TestCreator);
Expand Down
4 changes: 2 additions & 2 deletions tests/Eccube/Tests/Repository/CategoryRepositoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function testSave()
$name = $faker->name;
$Category = new Category();
$Category->setName($name)
->setLevel(1);
->setHierarchy(1);
$result = $this->app['eccube.repository.category']->save($Category);
$this->assertTrue($result);

Expand All @@ -186,7 +186,7 @@ public function testSaveWithException()
$name = $faker->name;
$Category = new Category();
$Category->setName($name)
->setLevel(null); // level は not null なので例外になる
->setHierarchy(null); // level は not null なので例外になる
$result = $this->app['eccube.repository.category']->save($Category);
$this->assertFalse($result);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public function testCategoryWithOut()
$Category
->setName('test')
->setRank(1)
->setLevel(1)
->setHierarchy(1)
->setCreateDate(new \DateTime())
->setUpdateDate(new \DateTime());
$this->app['orm.em']->persist($Category);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function testCategoryWithOut()
$Category
->setName('test')
->setRank(1)
->setLevel(1)
->setHierarchy(1)
->setCreateDate(new \DateTime())
->setUpdateDate(new \DateTime());
$this->app['orm.em']->persist($Category);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,13 @@ private function newTestCategory($TestCreator, $TestParentCategory = null)
if ($TestParentCategory == null) {
$TestCategory->setName('テスト家具')
->setRank(100)
->setLevel(100)
->setHierarchy(100)
->setParent($TestParentCategory)
->setCreator($TestCreator);
} else {
$TestCategory->setName($TestParentCategory->getName() . '_c')
->setRank($TestParentCategory->getRank() + 1)
->setLevel($TestParentCategory->getLevel() + 1)
->setHierarchy($TestParentCategory->getHierarchy() + 1)
->setParent($TestParentCategory)
->setCreator($TestCreator);
}
Expand Down
6 changes: 3 additions & 3 deletions tests/createEcCubeData-v30.php
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ public function createCategories()
$Category->setCreator($common_val['creator'])
->setDelFlg($common_val['del_flg'])
->setName(sprintf("Category%d00", $i))
->setLevel(1)
->setHierarchy(1)
->setRank($this->lfGetTotalCategoryrank($existingMaxRank) - $count);
$this->saveEntity($Category);
$this->arrCategory1[] = $Category;
Expand All @@ -460,7 +460,7 @@ public function createCategories()
->setName(sprintf("Category%d%d0", $i,
$j + MIDDLE_CATEGORIES_VOLUME))
->setParent($top_category)
->setLevel(2)
->setHierarchy(2)
->setRank($this->lfGetTotalCategoryrank($existingMaxRank) - $count);
$this->saveEntity($Category);
$this->arrCategory2[] = $Category;
Expand All @@ -477,7 +477,7 @@ public function createCategories()
$i, $j,
$k + SMALL_CATEGORIES_VOLUME))
->setParent($middle_category)
->setLevel(3)
->setHierarchy(3)
->setRank($this->lfGetTotalCategoryrank($existingMaxRank) - $count);
$this->saveEntity($Category);
$this->arrCategory3[] = $Category;
Expand Down

0 comments on commit 411def6

Please sign in to comment.