Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for NOTFOUND issue in some (or all) cases. #11

Closed
wants to merge 8 commits into from
Closed

Fix for NOTFOUND issue in some (or all) cases. #11

wants to merge 8 commits into from

Commits on Jun 30, 2017

  1. Fix for NOTFOUND issue in some (or all) cases. 

    Check that the CMAKE_PCH_COMPILER_TARGETS is not empty.
    mick-p1982 committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    3389828 View commit details
    Browse the repository at this point in the history

  2. Unrelated: Added quotes around -include term. 

    This is unrelated to the pull-request, but may as well go into it.
    mick-p1982 committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    fda58e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2017

  1. Incorporating nanoant#9

    Mick Pearson committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    ac93f3d View commit details
    Browse the repository at this point in the history

  2. Fix MSVC escapes.

    mick-p1982 committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    b117be4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2017

  1. https://gitlab.kitware.com/cmake/cmake/issues/17060

    mick-p1982 committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    a26810c View commit details
    Browse the repository at this point in the history

  2. Woops: Thought add_custom_target(ALL) meant go before ALL, but it see… 

    …ms to mean: wait for ALL and so go last.
    mick-p1982 committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    3d32634 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2017

  1. Use target_compile_option because set_target_properties is destructiv… 

    …e. And use PRIVATE, because PCHs should not be inherited by linked targets. Also, undo any effort in the prior commits to enable headers in sources. (It's not happening.)
    mick-p1982 committed Jul 15, 2017
    Configuration menu
    Copy the full SHA
    7386508 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2017

  1. If target_link_libraries is used, it must use PRIVATE to enable insta… 

    …ll(EXPORT)
    mick-p1982 committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    e97514a View commit details
    Browse the repository at this point in the history