Refactor: Create CompilationItemRepCollectionView

lib/nanoc/base/views.rb

@@ -13,6 +13,7 @@
 require_relative 'views/basic_item_rep_collection_view'
 
 require_relative 'views/compilation_item_rep_view'
+require_relative 'views/compilation_item_rep_collection_view'
 
 require_relative 'views/config_view'
 require_relative 'views/identifiable_collection_view'

lib/nanoc/base/views/basic_item_rep_collection_view.rb

@@ -23,8 +23,7 @@ def unwrap
 
     # @api private
     def view_class
-      # FIXME: Return Basic/CompilationItemRepView depending on case
-      Nanoc::CompilationItemRepView
+      Nanoc::BasicItemRepView
     end
 
     def to_ary

lib/nanoc/base/views/compilation_item_rep_collection_view.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module Nanoc
+  class CompilationItemRepCollectionView < ::Nanoc::BasicItemRepCollectionView
+    # @api private
+    def view_class
+      Nanoc::CompilationItemRepView
+    end
+  end
+end

lib/nanoc/base/views/item_with_reps_view.rb

@@ -39,7 +39,9 @@ def path(rep: :default, snapshot: :last)
     #
     # @return [Nanoc::BasicItemRepCollectionView]
     def reps
-      Nanoc::BasicItemRepCollectionView.new(@context.reps[unwrap], @context)
+      # FIXME: dedup into BasicItemWithRepsView and CompilationItemWithRepsView
+
+      Nanoc::CompilationItemRepCollectionView.new(@context.reps[unwrap], @context)
     end
   end
 end

spec/nanoc/base/views/basic_item_rep_collection_view_spec.rb

@@ -141,7 +141,5 @@
 
 describe Nanoc::BasicItemRepCollectionView do
   it_behaves_like 'an item rep collection view'
-  let(:expected_view_class) { Nanoc::CompilationItemRepView }
-
-  # FIXME: dedup into BasicBasicItemRepCollectionView and CompilationBasicItemRepCollectionView
+  let(:expected_view_class) { Nanoc::BasicItemRepView }
 end

spec/nanoc/base/views/compilation_item_rep_collection_view_spec.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+describe Nanoc::CompilationItemRepCollectionView do
+  it_behaves_like 'an item rep collection view'
+  let(:expected_view_class) { Nanoc::CompilationItemRepView }
+end

spec/nanoc/base/views/item_view_spec.rb

@@ -203,7 +203,7 @@
 
     it 'returns a proper item rep collection' do
       expect(subject.size).to eq(2)
-      expect(subject.class).to eql(Nanoc::BasicItemRepCollectionView)
+      expect(subject.class).to eql(Nanoc::CompilationItemRepCollectionView)
     end
 
     it 'returns a view with the right context' do