Merge pull request #692 from nanoc/pattern-from-inspect

Improve Pattern.from error message
nanoc · Aug 15, 2015 · 734efb1 · 734efb1
2 parents 72429ce + d2cf96d
commit 734efb1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/nanoc/base/entities/pattern.rb b/lib/nanoc/base/entities/pattern.rb
@@ -10,7 +10,7 @@ def self.from(obj)
       when Regexp
         Nanoc::Int::RegexpPattern.new(obj)
       else
-        raise ArgumentError, "Do not know how to convert #{obj} into a Nanoc::Pattern"
+        raise ArgumentError, "Do not know how to convert `#{obj.inspect}` into a Nanoc::Pattern"
       end
     end
 

diff --git a/spec/nanoc/base/entities/pattern_spec.rb b/spec/nanoc/base/entities/pattern_spec.rb
@@ -22,6 +22,11 @@
     it 'errors on other inputs' do
       expect { described_class.from(123) }.to raise_error(ArgumentError)
     end
+
+    it 'errors with a proper error message on other inputs' do
+      expect { described_class.from(nil) }
+        .to raise_error(ArgumentError, "Do not know how to convert `nil` into a Nanoc::Pattern")
+    end
   end
 
   describe '#initialize' do