Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lib_dir (Array<String>) support to configuration file. #424

Merged
merged 1 commit into from Apr 25, 2014

Conversation

gpakosz
Copy link
Member

@gpakosz gpakosz commented Apr 21, 2014

Makes nanoc load code snippets from configurable directories.

filename
)
end
@code_snippets.concat code_snippets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Braces around arguments here:

@code_snippets.concat(code_snippets)
``

@denisdefreyne
Copy link
Member

The create-site command (in lib/nanoc/cli/commands/create-site.rb) should be updated so that new configurations have the lib_dirs attribute.

@denisdefreyne
Copy link
Member

👍 otherwise.

Makes nanoc load code snippets from configurable directories.
@gpakosz
Copy link
Member Author

gpakosz commented Apr 25, 2014

Updated. Not sure about create-site command since the current default configuration populated by the create-site command doesn't contain everything nanoc can do: e.g. static data sources

@denisdefreyne
Copy link
Member

Yeah, maybe skipping the create-site changes is okay.

To do: update the documentation on the web site. (I will tackle that later when I write the 3.7 documentation.)

denisdefreyne added a commit that referenced this pull request Apr 25, 2014
@denisdefreyne denisdefreyne merged commit 7b2957b into nanoc:master Apr 25, 2014
@gpakosz gpakosz deleted the configurable-lib-dir branch July 15, 2014 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants