Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed english text from link_to helper. #736

Merged
merged 3 commits into from Nov 28, 2015
Merged

Removed english text from link_to helper. #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94ae4be
Removed english text from link_to helper.
lvuotto Nov 27, 2015
86a262d
Fix `link_to_unless_current` tests accordingly.
lvuotto Nov 28, 2015
cf2e441
Change `link_to_unless_current` comment.
lvuotto Nov 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/nanoc/helpers/link_to.rb
View file
Open in desktop
Expand Up @@ -82,14 +82,14 @@ def link_to(text, target, attributes = {})
# @example Linking to the same page
#
# link_to_unless_current('This Item', @item)
# # => '<span class="active" title="You\'re here.">This Item</span>'
# # => '<span class="active">This Item</span>'
def link_to_unless_current(text, target, attributes = {})
# Find path
path = target.is_a?(String) ? target : target.path

if @item_rep && @item_rep.path == path
# Create message
"<span class=\"active\" title=\"You're here.\">#{text}</span>"
"<span class=\"active\">#{text}</span>"
else
link_to(text, target, attributes)
end
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/test_link_to.rb
View file
Open in desktop
Expand Up @@ -67,7 +67,7 @@ def test_link_to_unless_current_current

# Check
assert_equal(
'<span class="active" title="You\'re here.">Bar</span>',
'<span class="active">Bar</span>',
link_to_unless_current('Bar', @item_rep),
)
ensure
Expand Down