Use Nokogiri for HTML check #965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
html-nokogiri-check
branch
from
79d2bb4
to
dedde75
Compare
|
Closing, as this is not a good enough check. |
|
For an alternative, see nanoc/nanoc.app@44ccc8b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops using
w3c_validatorsfor the HTML check, and rather relies on Nokogiri’s built-in HTML validation features. As Nokogiri does not support HTML5, this change also ignores errors for HTML5 and SVG tags.To do
Open questions
<span><div>…</div></span>). Is there an alternative?Related issues
Fixes #943.