Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node Telemetry details #219

Closed
zhyatt opened this issue Feb 3, 2020 · 9 comments · Fixed by #231
Closed

Add Node Telemetry details #219

zhyatt opened this issue Feb 3, 2020 · 9 comments · Fixed by #231
Assignees
Milestone

Comments

@zhyatt
Copy link
Contributor

zhyatt commented Feb 3, 2020

RPC command additions and other details to help make telemetry useful (response definitions?)

Related to: nanocurrency/nano-node#2446 and nanocurrency/nano-node#2521

@zhyatt zhyatt added this to the V21.0 milestone Feb 3, 2020
@zhyatt
Copy link
Contributor Author

zhyatt commented Feb 10, 2020

@wezrule
Copy link
Contributor

wezrule commented Feb 14, 2020

Also: nanocurrency/nano-node#2560

@wezrule
Copy link
Contributor

wezrule commented Feb 14, 2020

Done in #231

@wezrule wezrule mentioned this issue Feb 15, 2020
@wezrule
Copy link
Contributor

wezrule commented Mar 20, 2020

@wezrule
Copy link
Contributor

wezrule commented Apr 21, 2020

And nanocurrency/nano-node#2728

@zhyatt zhyatt reopened this Jun 8, 2020
@zhyatt
Copy link
Contributor Author

zhyatt commented Jun 8, 2020

@wezrule Can you verify the published telemetry details across RPC and WebSocket responses? It seems like active_difficulty, address and port are inconsistent between the two.

@wezrule
Copy link
Contributor

wezrule commented Jun 9, 2020

@zhyatt active_difficulty was missing from websocket, good catch! address & port are always in websocket, but only in RPC when raw is set to true. Another possible inconsistency though is that websocket "topic" uses telemetry while RPC uses node_telemetry, hmm, would it make sense if they were the same?

@zhyatt
Copy link
Contributor Author

zhyatt commented Jun 9, 2020

@wezrule Thanks for updating. I think consistency would be good here. Perhaps an update on the websocket topic to be node_telemetry to be more explicit would make sense.

@zhyatt
Copy link
Contributor Author

zhyatt commented Jun 9, 2020

Updating all internally to use just telemetry while sometimes referred to as "node telemetry" in communications and such. Related #322 and nanocurrency/nano-node#2804

@zhyatt zhyatt closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants