Extend telemetry data with more node versioning details #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
documentation
cryptocode
previously approved these changes
Jan 30, 2020
argakiig
previously approved these changes
Jan 30, 2020
guilhermelawless
previously approved these changes
Jan 30, 2020
wezrule
dismissed stale reviews from guilhermelawless, argakiig, and cryptocode
via
d614030
argakiig
approved these changes
Jan 31, 2020
guilhermelawless
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json requested knowing more details about the node version rather than just the major version. Added
minor_version&patch_version, renamedvendor_versiontomajor_version. Nox also suggested adding a "maker" for third party nodes, where 0 is defaulted as being for the Nano Foundation node. Also added CMake variable for a new concept of "pre release" so that there is a clear distinction between that future patch versions.This telemetry data has been added as optional so we can also test the backwards/forwards compatibility in the DB too.