Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RPC name consistent with stats, websocket & protocol naming for telemetry #2804

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Make RPC name consistent with stats, websocket & protocol naming for telemetry #2804

merged 1 commit into from
Jun 10, 2020

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Jun 9, 2020

Also updated some other places to use telemetry instead of node_telemetry

@wezrule wezrule added documentation This item indicates the need for or supplies updated or expanded documentation telemetry rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted. labels Jun 9, 2020
@wezrule wezrule added this to the V21.0 milestone Jun 9, 2020
@wezrule wezrule self-assigned this Jun 9, 2020
@wezrule wezrule mentioned this pull request Jun 9, 2020
Merged
guilhermelawless
guilhermelawless approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@guilhermelawless guilhermelawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, grep -r node_telemetry nano/ comes up empty.

@zhyatt zhyatt mentioned this pull request Jun 9, 2020
Closed
@wezrule wezrule merged commit b5fcb7c into nanocurrency:develop Jun 10, 2020
@wezrule wezrule deleted the consistent_telemetry_naming branch June 10, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermelawless guilhermelawless guilhermelawless approved these changes

Assignees

@wezrule wezrule

Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted. telemetry
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wezrule @guilhermelawless